Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Remove useless NoReturn in NodeNG.statement's typing (#1304)"" #1319

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Revert "Revert "Remove useless NoReturn in NodeNG.statement's typing (#1304)"" #1319

merged 1 commit into from
Dec 29, 2021

Conversation

tushar-deepsource
Copy link
Contributor

Reverts #1307

@Pierre-Sassoulas
Copy link
Member

Blocked by #1316

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.9.1 milestone Dec 29, 2021
@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining astroid or the dev workflow Blocked 🚧 A PR or issue blocked by another PR or issue labels Dec 29, 2021
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to the bottom of the issue !

@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 A PR or issue blocked by another PR or issue label Dec 29, 2021
@Pierre-Sassoulas
Copy link
Member

Nvm, as @cdce8p said, we can merge before fixing #1316 when we see that the fail are unrelated to the changes.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 7afd696 into pylint-dev:main Dec 29, 2021
@cdce8p
Copy link
Member

cdce8p commented Dec 29, 2021

Thanks @tushar-deepsource!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tushar-deepsource @Pierre-Sassoulas @cdce8p