Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyError when using create_observation() in dry-run mode #538

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented Jan 10, 2024

Plus some other improvements for mock responses. Fixes #536.

@JWCook JWCook added the bug Something isn't working label Jan 10, 2024
@JWCook JWCook added this to the v0.19 milestone Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a1250e) 95.98% compared to head (3061faf) 95.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   95.98%   95.99%           
=======================================
  Files          59       59           
  Lines        3314     3319    +5     
  Branches      635      635           
=======================================
+ Hits         3181     3186    +5     
  Misses         95       95           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JWCook JWCook merged commit 4e19a7a into main Jan 10, 2024
9 of 10 checks passed
@JWCook JWCook deleted the mock-response branch January 10, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Dry Run throws a key error
1 participant