Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor controller methods #529

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Refactor controller methods #529

merged 3 commits into from
Dec 11, 2023

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented Dec 11, 2023

In exchange for more code/doc duplication, I think this makes controller methods simpler and easier to follow. Or, rather, I think my previous attempts at code reuse may have hurt readability a bit.

This also adds several previously missing docstrings.

@JWCook JWCook added the refactoring (Re)factoring, cleanup, tech debt, etc. label Dec 11, 2023
@JWCook JWCook added this to the v1.0 milestone Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a086ac6) 96.35% compared to head (5d00c3a) 95.96%.
Report is 6 commits behind head on main.

Files Patch % Lines
...yinaturalist/controllers/observation_controller.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
- Coverage   96.35%   95.96%   -0.39%     
==========================================
  Files          58       58              
  Lines        3294     3298       +4     
  Branches      643      635       -8     
==========================================
- Hits         3174     3165       -9     
- Misses         88       95       +7     
- Partials       32       38       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JWCook JWCook merged commit 1c03d5c into main Dec 11, 2023
7 of 8 checks passed
@JWCook JWCook deleted the controller-refactor branch December 11, 2023 23:48
JWCook added a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring (Re)factoring, cleanup, tech debt, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant