Port joystick and scrap to SDL3

[ankith26]

This PR ports joystick and scrap to SDL3.

Porting scrap turned out to be surprisingly trivial, but it makes sense given that we are using like 3 functions of the SDL API, and the rest are custom implementations.
EDIT: There was some windows specific code that I initially missed when I made this comment, but that should hopefully be ported now as well.

[Starbuck5]

Thanks!

[ankith26]

Something I didn't think about while making the PR: SDL_GetJoystickGUIDForID uses the instance ID and not the device ID returned by pgJoystick_AsID. This block needs more attention and thought

[zoldalma999]

In general the joystick port will need some more thought. They removed device indices completely, meaning we need to rework the initialization of joystick objects in general. There is no easy way to emulate this either (and we shouldn't anyway!).

With that said, you can use SDL_GetJoystickID to get the instance_id of an already open joystick.

[MyreMylar]

It seems like we may need to store something like initial_instance_id or last_known_instance_id on the pygame Joystick object.

at the minute it has these attributes:

jstick->id = id; // ID passed in by the user in range 0 to number of connected joysticks at time of creation - called 'device id'
jstick->joy = joy; // SDL Joystick Object
jstick->prev = NULL;
jstick->next = joylist_head;

It is a bit of an odd code path here, as you only go down it when the SDLJoystick object is invalid - which shouldn't happen, and I'm not sure why you'd want the GUID of an invalid SDL Joystick or if it would even produce any usable output. Are we testing this code path at all?

The instance id of an SDLJoystick changes to a unique number whenever a joystick is connected or disconnected. We are checking the instance ID in this case when we explicitly cannot get the SDL Joystick object - perhaps because it has been disconnected.

At the minute the joystick module has no support for 'hot plugging' or plugging & unplugging controllers and we probably shouldn't try and add it in as simple conversion PR - we also have the newer controller module for that sort of thing.

I would probably just store the initial instance id when we first create the joystick, like we do the device id, and then add another pg function to get it like we do the device ID. We could also update the last_known_instance_id in get_guid()

I notice there was also a lot of renaming in the joystick module:
libsdl-org/SDL#6881

I'm sure this has been covered somewhere, but are we intending to eventually rename our SDL function calls as well? Or just relying on the SDL 'old names' wrapper?