Port key and mouse to SDL3 #3207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
reviewed
Nov 2, 2024
|
I wanted to test this, so I rebased against main and ran I got the following warnings-to-errors: ../src_c/mouse.c(100): error C2220: the following warning is treated as an error
../src_c/mouse.c(100): warning C4244: '=': conversion from 'int' to 'float', possible loss of data
../src_c/mouse.c(101): warning C4244: '=': conversion from 'int' to 'float', possible loss of data
../src_c/mouse.c(109): warning C4244: '=': conversion from 'int' to 'float', possible loss of data
../src_c/mouse.c(113): warning C4244: '=': conversion from 'int' to 'float', possible loss of data
../src_c/mouse.c(118): warning C4244: 'function': conversion from 'float' to 'int', possible loss of data
../src_c/mouse.c(118): warning C4244: 'function': conversion from 'float' to 'int', possible loss of data
../src_c/mouse.c(149): warning C4244: 'function': conversion from 'float' to 'int', possible loss of data
../src_c/mouse.c(149): warning C4244: 'function': conversion from 'float' to 'int', possible loss of data
../src_c/mouse.c(253): warning C4244: '=': conversion from 'SDL_WindowFlags' to 'Uint32', possible loss of data |
ankith26
force-pushed
the
ankith26-more-sdl3-2
branch
from
8bf0cd7 to
f1e61a6
Compare
|
I have rebased this branch on main and force pushed. Previously I didn't see these warnings on CI but lets see how things go now UPDATE: Could reproduce those fails on CI, so force pushed again with fixes for that |
ankith26
force-pushed
the
ankith26-more-sdl3-2
branch
from
f1e61a6 to
634619b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just following the footsteps of #3206 but separated out in a different PR because these changes are not as trivial as those