Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance pygame.mouse.get_pressed docs #3084

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

damusss
Copy link
Member

@damusss damusss commented Aug 27, 2024

@pgvalle made me notice that the documentation for the function pygame.mouse.get_pressed could be improved to say something about the button constants. Since I was enhancing, I also removed some trailing whitespaces, added some quotes around pygame constants and reordered the notions inside the get_pressed function body (I made one note an actual .. note:: and converted 2 notes to description.)

I find it to be better, but it is subjective, so let me know.

@damusss damusss added docs mouse pygame.mouse labels Aug 27, 2024
@damusss damusss requested a review from a team as a code owner August 27, 2024 13:01
@damusss damusss changed the title Enhance mouse docs Enhance pygame.mouse.get_pressed docs Aug 27, 2024
docs/reST/ref/mouse.rst Outdated Show resolved Hide resolved
docs/reST/ref/mouse.rst Outdated Show resolved Hide resolved
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@ankith26 ankith26 added this to the 2.5.2 milestone Sep 17, 2024
Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this PR a while ago, but forgot to leave feedbacks. LGTM now, thanks for the PR.

@bilhox bilhox merged commit d6e61c9 into pygame-community:main Sep 17, 2024
3 checks passed
@damusss damusss deleted the mouse-pressed-enhance-docs branch September 17, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs mouse pygame.mouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants