Add pygame.mixer_music.Queue
#3057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damusss
added
New API
|
I think this need a very explicative issue on how it works otherwise some people can be confused on what it does exactly. |
|
reference to #3058 |
|
We have to rework mixer_music and put more thought into it, and that won't happen very soon, this PR doesn't make much sense existing IMO. I will only keep the branch as a backup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs and stubs are already included. Missing tests and docstrings.
It is not guaranteed to pass the checks as the C code gave me headaches locally and will probably fail remotely (hope not).
The stubs pass the stubcheck.py.
The implementation uses a little bit of help from C but it is mainly pythonic. Except for the Queue class no API is modified.
The idea was proposed by @bilhox and it looks like there is already someone that would like it.
API changes or renames are welcome. I can name stop() and resume() to pause() and unpause() if you prefer.