Remove unnecessary pixeloffset member of subsurface data #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was digging around our structs and found this member barely used anywhere. All it did was set the subsurf pixel pointer to the correct location when pgSurface_Prep is called. But the subsurf pixel pointer is set up to point at the right location in surface.subsurface already, and never changes from that position. So storing the offset and re-setting it occasionally is unnecessary effort.
Starbuck5
force-pushed
the
remove-unnecessary-subsurf-data
branch
from
107daff to
8b48d66
Compare
MyreMylar
approved these changes
Jul 25, 2024
ankith26
approved these changes
Jul 28, 2024
| pgSurface_LockBy((pgSurfaceObject *)data->owner, (PyObject *)surfobj); | ||
| surf->pixels = ((char *)owner->pixels) + data->pixeloffset; |
There was a problem hiding this comment.
The code being removed here is so weird, I wonder if there was any intention behind this... IG we will never know
There was a problem hiding this comment.
I investigated a little further, it's been like this since surflock.c was created 24 years ago! pygame/pygame@45784b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was digging around our structs and found this member barely used anywhere. All it did was set the subsurf pixel pointer to the correct location when pgSurface_Prep is called. But the subsurf pixel pointer is set up to point at the right location in surface.subsurface already, and never changes from that position. So storing the offset and re-setting it occasionally is unnecessary effort.
How did I verify it was unnecessary?
pixelsto something else on a surface. (So if nothing is messing it up, no need to reset it)This makes the subsurface code a tiny bit simpler and more memory efficient.