Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python 3.8 isms in the type stubs #2995

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Use python 3.8 isms in the type stubs #2995

merged 1 commit into from
Jul 16, 2024

Conversation

ankith26
Copy link
Member

Protocol, SupportsIndex, Literal and TypedDict were all added in Python 3.8

We can make use of these directly with a typing import as our minimum supported python version is 3.8

Protocol, SupportsIndex, Literal and TypedDict were all added in Python 3.8
@ankith26 ankith26 added the type hints Type hint checking related tasks label Jul 15, 2024
@ankith26 ankith26 requested a review from a team as a code owner July 15, 2024 12:31
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some of these cleanups look really satisfying

Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@damusss damusss added this to the 2.5.1 milestone Jul 16, 2024
@damusss damusss merged commit 970e2b3 into main Jul 16, 2024
36 checks passed
@ankith26 ankith26 deleted the ankith26-typing-py38 branch July 16, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type hints Type hint checking related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants