Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python -m buildconfig now works again... #2989

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

oddbookworm
Copy link
Member

Yeah, in #2942, I overlooked something silly and broke python -m buildconfig itself lol. This fixes that. Although, I have some ideas that might come in a PR soon that'll revamp this whole thing

@oddbookworm oddbookworm added buildconfig bugfix PR that fixes bug labels Jul 13, 2024
@oddbookworm oddbookworm requested a review from a team as a code owner July 13, 2024 15:32
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it currently raises an IndexError, this fixes it

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing this got fixed before 2.5.1, thanks!

@ankith26 ankith26 added this to the 2.5.1 milestone Jul 13, 2024
@damusss damusss merged commit cdc2756 into pygame-community:main Jul 13, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR that fixes bug buildconfig
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants