Remove obsolete surflock functions #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
added
Code quality/robustness
Starbuck5
force-pushed
the
remove-obsolete-surflock-functions
branch
from
8dc6984 to
9778f43
Compare
ankith26
approved these changes
Jul 7, 2024
damusss
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2018, llindstrom wrote of pgSurface_LockLifetime in surflock.rst that "This function is not called anywhere within pygame. It and pgLifetimeLock_Type are candidates for removal."
In the intervening 6 years, the functions and documentation have not been meaningfully edited, and these systems are still not used anywhere.
So let's remove them.