Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed dark theme slightly to make code more readable in some cases #2960

Merged

Conversation

oddbookworm
Copy link
Member

Current version of https://pyga.me/docs/tutorials/en/chimp-explanation.html
image

This PR's version
image

Someone reported that code blocks can be hard to read because of the dark blue function names sometimes, so I fixed it. As far as I know, I got all the cases, but please lmk if I missed any

@oddbookworm oddbookworm requested a review from a team as a code owner June 30, 2024 01:08
@itzpr3d4t0r
Copy link
Member

Not a real review but why must everything be green? Like it's a bit sickening.

@oddbookworm
Copy link
Member Author

I chose it semi-arbitrarily. Seemed like it would fit in with the rest of the theme. Alternative color suggestions welcome

@damusss
Copy link
Member

damusss commented Jun 30, 2024

I chose it semi-arbitrarily. Seemed like it would fit in with the rest of the theme. Alternative color suggestions welcome

[copied from discord]
I think some kind of light blue is fine, like #50b0fa, but i got that from a color picker quickly so maybe you can do better

@oddbookworm
Copy link
Member Author

@damusss @itzpr3d4t0r here's what it looks like with the color suggested
image

@damusss
Copy link
Member

damusss commented Jul 7, 2024

@damusss @itzpr3d4t0r here's what it looks like with the color suggested
image

The color I suggested is very similar to strings and class names. While it's not a problem to me, what about yellow? My vs code theme has it and it's great (we could use my color for the class name imo, it's brighter)

@MyreMylar
Copy link
Member

Looks like this:

image

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. More readable.

Copy link
Member

@itzpr3d4t0r itzpr3d4t0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itzpr3d4t0r itzpr3d4t0r merged commit 4b5d83d into pygame-community:main Jul 28, 2024
1 check passed
@itzpr3d4t0r itzpr3d4t0r added this to the 2.5.1 milestone Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants