-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed dark theme slightly to make code more readable in some cases #2960
Changed dark theme slightly to make code more readable in some cases #2960
Conversation
Not a real review but why must everything be green? Like it's a bit sickening. |
I chose it semi-arbitrarily. Seemed like it would fit in with the rest of the theme. Alternative color suggestions welcome |
[copied from discord] |
@damusss @itzpr3d4t0r here's what it looks like with the color suggested |
The color I suggested is very similar to strings and class names. While it's not a problem to me, what about yellow? My vs code theme has it and it's great (we could use my color for the class name imo, it's brighter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. More readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Current version of https://pyga.me/docs/tutorials/en/chimp-explanation.html
This PR's version
Someone reported that code blocks can be hard to read because of the dark blue function names sometimes, so I fixed it. As far as I know, I got all the cases, but please lmk if I missed any