Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make window subclassable #2950

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Make window subclassable #2950

merged 1 commit into from
Jun 28, 2024

Conversation

zoldalma999
Copy link
Member

Fixes #2625

@zoldalma999 zoldalma999 requested a review from a team as a code owner June 23, 2024 11:27
ankith26
ankith26 reviewed Jun 23, 2024
View reviewed changes
src_c/window.c Outdated Show resolved Hide resolved
@yunline yunline added the window pygame.Window label Jun 24, 2024
ankith26
ankith26 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

damusss
damusss approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM :)

@damusss damusss merged commit bef0d2e into pygame-community:main Jun 28, 2024
39 checks passed
@damusss damusss added this to the 2.5.1 milestone Jun 28, 2024
@zoldalma999 zoldalma999 deleted the window-subclass branch October 22, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusss damusss damusss approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
window pygame.Window
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.

Window should be subclassable
4 participants
@zoldalma999 @ankith26 @damusss @yunline