Add default dest (0, 0) to Surface.blit #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
reviewed
Jun 18, 2024
ankith26
approved these changes
Jun 19, 2024
itzpr3d4t0r
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2935
I'm not sure if you want this to be added, personally I like it. I didn't discuss it because the implementation seemed pretty simple, so even if you don't want it it's not a big deal.
The reasoning for it can be understood in the issue description.
I only modified blit and not blits/fblits, but I'm pretty sure I can add it to them too if you want, but for now I don't think it's a good idea.