Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lint logic from setup.py #2796

Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 9, 2024

Followup to

Pylint is too slow to run in pre-commit but let's keep it running in GitHub Actions.
This could be sped up radically with ruff check --select=PL but that could be a future enhancement.

@cclauss cclauss requested a review from a team as a code owner April 9, 2024 15:24
setup.py Outdated Show resolved Hide resolved
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, thanks!

I'd like to give this PR a small wait, just so that the other devs can get onboard the pre-commit strategy and not have any issues with it.

@oddbookworm
Copy link
Member

I'd like to give this PR a small wait, just so that the other devs can get onboard the pre-commit strategy and not have any issues with it.

FWIW I'm on board with pre-commit

Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on board with this

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go ahead and approve this, but I'd like someone else to merge this just so that this change has more visibility.

Thanks for the PR 💯

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'm on board with this pre-commit strategy as well. I mean in principle I'm on board with it, when it inevitably catches me out later when I forget about it I reserve the right to complain petulantly.

@MyreMylar MyreMylar merged commit 8d59876 into pygame-community:main Apr 28, 2024
30 checks passed
@cclauss cclauss deleted the remove-lint-logic-from-setup.py branch April 28, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants