-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lint logic from setup.py #2796
Remove lint logic from setup.py #2796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes, thanks!
I'd like to give this PR a small wait, just so that the other devs can get onboard the pre-commit strategy and not have any issues with it.
FWIW I'm on board with pre-commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on board with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will go ahead and approve this, but I'd like someone else to merge this just so that this change has more visibility.
Thanks for the PR 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'm on board with this pre-commit strategy as well. I mean in principle I'm on board with it, when it inevitably catches me out later when I forget about it I reserve the right to complain petulantly.
Followup to
python3 setup.py lint
is deprecated: Let's lint withpre-commit
#2772Pylint is too slow to run in pre-commit but let's keep it running in GitHub Actions.
This could be sped up radically with
ruff check --select=PL
but that could be a future enhancement.