Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Window API that will be questionable in SDL3 #2617

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Remove Window API that will be questionable in SDL3 #2617

merged 1 commit into from
Dec 23, 2023

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Dec 20, 2023 •
edited
Loading

For #2603, see #2603 (comment) for details

@Starbuck5 Starbuck5 added sdl3 window pygame.Window labels Dec 20, 2023
@Starbuck5 Starbuck5 added this to the 2.4.0 milestone Dec 20, 2023
@Starbuck5 Starbuck5 requested a review from yunline December 20, 2023 07:14
@Starbuck5 Starbuck5 requested a review from a team as a code owner December 20, 2023 07:14
@Starbuck5 Starbuck5 force-pushed the cleanup-window-for-sdl3 branch from aa2bdbd to b9f80dc Compare December 20, 2023 07:19
yunline
yunline approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

ankith26
ankith26 reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other removals look good, just one question is left as a review

src_c/window.c Show resolved Hide resolved
ankith26
ankith26 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets get this in! 💯

@Starbuck5 Starbuck5 merged commit 4258630 into pygame-community:main Dec 23, 2023
30 checks passed
@Starbuck5 Starbuck5 deleted the cleanup-window-for-sdl3 branch December 23, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@yunline yunline yunline approved these changes

Assignees
No one assigned
Labels
sdl3 window pygame.Window
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Starbuck5 @yunline @ankith26