SDL_image 2.8.0 #2595
Merged
SDL_image 2.8.0 #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From local investigation, the 3.11-32 and 3.12-32 failures come from a segfault when attempting to load webp images. I have no idea how this could be dependent on Python version. EDIT: More local testing shows webp segfaulting on all 32 bit. |
|
I'm out of debugging ideas about windows 32 bit, so I've brought this up to the SDL_image issue tracker libsdl-org/SDL_image#403 |
|
Windows issues resolved with a fresh build of libwebp from SDL_image. Thanks sezero! |
Starbuck5
merged commit fd129e9
into
pygame-community:starbuck-sdl-image-bump
20 of 30 checks passed
|
Merged to a repo branch from a fork branch so Linux build changes can be made with necessary permissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a long time coming, since we've decided we need SDL_image built with libpng, and SDL_image prebuilts after 2.0.5 don't come with that.
This PR hopes to get around that using CI on a pygame-community fork of SDL_image (https://github.com/pygame-community/SDL_image/releases/tag/2.8.0-pgce) to generate release bundles with our parameters.
This allows our Windows CI and local development workflow to remain almost exactly the same through this change.