Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclassing Sounds + Channels. #2590

Merged
merged 4 commits into from
Dec 10, 2023

Conversation

gresm
Copy link
Contributor

@gresm gresm commented Nov 24, 2023

Fixes #2589
(Or at least it should)

@gresm gresm requested a review from a team as a code owner November 24, 2023 12:06
@gresm gresm marked this pull request as draft November 24, 2023 12:12
@gresm gresm marked this pull request as ready for review November 24, 2023 14:45
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🥳

@Starbuck5 Starbuck5 added the mixer pygame.mixer label Nov 26, 2023
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay on a relook, maybe this PR also needs a little docs addition in the Channel class saying that it is now subclassable?

@gresm
Copy link
Contributor Author

gresm commented Nov 27, 2023

@ankith26 done

@gresm gresm requested a review from ankith26 November 27, 2023 10:00
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for the PR 🎉

@ankith26 ankith26 added this to the 2.4.0 milestone Dec 8, 2023
@Starbuck5 Starbuck5 merged commit 5482b63 into pygame-community:main Dec 10, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mixer pygame.mixer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pygame.mixer.Channel.queue does not support pygame.mixer.Sound derivative class instances
4 participants