Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiline more examples #2588

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Multiline more examples #2588

merged 8 commits into from
Dec 13, 2023

Conversation

gresm
Copy link
Contributor

@gresm gresm commented Nov 23, 2023 •
edited
Loading

Resolves one sub-task from #2206

This PR:

  • examples/textinput.py - now uses multi-line font rendering
  • examples/textinput.py - fix visual errors with text looking weird
  • examples/textinput.py - mypy no longer upset
  • examples/vgrade.py - PEP 8 exists

@gresm gresm requested a review from a team as a code owner November 23, 2023 12:12
oddbookworm
oddbookworm previously requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like reasonable changes, just one small nitpick about type hinting

examples/textinput.py Outdated Show resolved Hide resolved
@gresm gresm requested a review from oddbookworm November 23, 2023 20:56
MyreMylar
MyreMylar approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine 👍

@Matiiss Matiiss mentioned this pull request Nov 25, 2023
Closed
7 tasks
Starbuck5
Starbuck5 reviewed Dec 6, 2023
View reviewed changes
examples/textinput.py Outdated Show resolved Hide resolved
Starbuck5
Starbuck5 reviewed Dec 6, 2023
View reviewed changes
examples/textinput.py Outdated Show resolved Hide resolved
Starbuck5
Starbuck5 reviewed Dec 6, 2023
View reviewed changes
examples/textinput.py Outdated Show resolved Hide resolved
@gresm gresm requested a review from oddbookworm December 12, 2023 12:17
Starbuck5
Starbuck5 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Starbuck5 Starbuck5 merged commit b560863 into pygame-community:main Dec 13, 2023
1 of 2 checks passed
@ankith26 ankith26 added this to the 2.4.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matiiss Matiiss Matiiss left review comments

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

@oddbookworm oddbookworm Awaiting requested review from oddbookworm

Assignees
No one assigned
Labels
examples
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@gresm @MyreMylar @Starbuck5 @oddbookworm @Matiiss @yunline @ankith26