Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoothscale: deprecate old backends, update docs #2583

Merged

Conversation

Starbuck5
Copy link
Member

Follows on from story started in #2473 and #2544.

The old backends are marked deprecated. I don't want to remove them yet in case bugs are found in the new implementations. Having the old ones around allows users to work around by setting it to use the old ones explicitly.

@Starbuck5 Starbuck5 requested a review from a team as a code owner November 22, 2023 07:28
@Starbuck5 Starbuck5 force-pushed the deprecate-old-smoothscale-and-docs branch from bccd402 to 6ce8456 Compare November 22, 2023 07:32
@Starbuck5 Starbuck5 force-pushed the deprecate-old-smoothscale-and-docs branch from 6ce8456 to e608dd9 Compare November 22, 2023 07:32
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be also nice to have a unit test testing the deprecation

*If they are even possible to set
@Starbuck5
Copy link
Member Author

Would be also nice to have a unit test testing the deprecation

I thought of this but I didn't include it initially since it seems very minor, I've included it now.

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@ankith26 ankith26 added this to the 2.4.0 milestone Nov 25, 2023
@ankith26 ankith26 merged commit d9533f4 into pygame-community:main Nov 25, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants