Strip the leading SDL_ from the pixel format name

[MyreMylar]

Fixes issue #1741.

I'm not sure this is the best way to strip 4 characters from a C string, so please let me know.

[ankith26]

A one-line change to achieve this could be passing pixel_format_name + 4 directly instead of the copying to new memory. This of course, assumes that pixel_format_name is a non-null pointer and the string has atleast 4 chars (which should be checked, either way)

[ankith26]

if (!strncmp(pixel_format_name, "SDL_", 4)) {
    pixel_format_name += 4
}

(untested code)
This should do maybe?

[zoldalma999]

The vidinfo type also has a getter, defined a bit above the str function. This currently does not even return a value for pixel format, so I think this could be an opportunity to fix that (and of course, strip "SDL_" off there as well).

ps: SDL_GetPixelFormatName will always return a string starting with "SDL_"

[ankith26]

ps: SDL_GetPixelFormatName will always return a string starting with "SDL_"

Yeah I realised that too as I made my comment, but then it's safer (more future-proof) this way and does no harm.

[MyreMylar]

The vidinfo type also has a getter, defined a bit above the str function. This currently does not even return a value for pixel format, so I think this could be an opportunity to fix that (and of course, strip "SDL_" off there as well).

Should work now:

import pygame

pygame.init()
print(pygame.display.Info().pixel_format)

Output:

pygame-ce 2.4.0.dev1 (SDL 2.26.5, Python 3.11.1)
PIXELFORMAT_RGB888

[zoldalma999]

Looks good to me!

[MyreMylar]

Documented the pixel_format attribute and fixed that attribute documentation block while I was in there. Before it was formatted as python code and had an unnecessarily messy horizontal scrollbar.

👍

[ankith26]

LGTM, thanks for the PR 🎉