-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try getting freetype tests running on CI, fix minor test fail issues #2370
Conversation
The freetype test 'test_freetype_Font_name' is expected to fail with current code, working on a fix right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR is good, but should we have the behavior change in here at all? It's from #2175 It changes freetype.Font.name to raise an AttributeError on un-initialized freetype.Fonts. This changes the behavior, the change is not documented, and breaks the test now that it runs. |
It was a PR-feedback that suggested to change that since 'repr(font)' is confusing when calling |
Here is the follow up PR to catch all uninitialized fonts: |
[BACKPORT OF #2370] Try getting freetype tests running on CI, fix minor test fail issues
No description provided.