-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump SDL to 2.26.4 (along with other deps bumps) #2057
Conversation
This looks pretty straightforward, the deletion of jpeg seems like the strangest thing in the PR. I assume we were using libjpeg-turbo already and this just cleans up the unused libjpeg. Edit: okay yeah that is what is going on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I don't have easy access to a system to test this locally right now, so I haven't.
I'd like somebody to test the new wheels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks fine to me also, but it makes sense to have someone not on a windows machine actually try out these wheels.
I assume we can do that from this PR, I have the loosest understanding of this process that goes:
- docker builds the manylinux wheels.
- We distribute them via PyPI.
I have no clue if there is a button one has to hit to make step 1 happen with this PR active. Or do we need to merge it first to make docker build the wheels?
Looks good on my side. Ran a few test scripts and I didn't notice any problems
|
I also validated this on my Mac. My testing didn't turn up any problems
|
Basically mac/manylinux companion of #1986 along with a bunch of other related dependency updates sprinked in for good measure.
This may conflict with my older #1997 (which may need more testing/tinkering) so I'd like this to be merged first