-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SGFormer
model and example
#9904
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9904 +/- ##
==========================================
+ Coverage 85.84% 86.31% +0.46%
==========================================
Files 490 492 +2
Lines 32537 32696 +159
==========================================
+ Hits 27932 28220 +288
+ Misses 4605 4476 -129 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please put the Model from example into torch_geometric.nn.models
then also put a unit test under test/nn/models.
then please integrate the model into examples/ogbn_train.py.
do this with "--gnn-choice" arg parse option, with choices ["sage, gat, polynormer_graph_transformer"]
please share the log of all 3 and then change the default to the best
for more information, see https://pre-commit.ci
examples/ogbn_train.py
|
awesome! can you add the same setup to examples/ogbn_train_cugraph.py and examples/multi_gpu/ogbn_train_cugraph.py and run the same tests |
for more information, see https://pre-commit.ci
btw i ran papers100 got 65% test acc (waiting to hear back from a colleague what the latest results for gat and sage are to save myself some re-doing effort) |
I was stuck in installing the cugraph_pyg env with conda. I am installing nv-pyg docker, after that, will test it under cugraph env |
examples/ogbn_train_cugraph.py
ogbn_cugraph_gat.log examples/multi_gpu/ogbn_train_cugraph.py
ogbn_cugraph_multi_gat.log |
Issue
SGFormer
model onogbn-arxiv
dataset.Usage
python examples/sgformer.py
Highlight
Results
ogbn-arxiv