Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HANConv: NaN handling #4841

Merged
merged 2 commits into from
Jun 22, 2022
Merged

HANConv: NaN handling #4841

merged 2 commits into from
Jun 22, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Jun 22, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #4841 (93fe714) into master (3d76627) will decrease coverage by 1.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4841      +/-   ##
==========================================
- Coverage   84.58%   82.71%   -1.88%     
==========================================
  Files         326      326              
  Lines       17521    17520       -1     
==========================================
- Hits        14821    14491     -330     
- Misses       2700     3029     +329     
Impacted Files Coverage Δ
torch_geometric/nn/conv/han_conv.py 100.00% <100.00%> (ø)
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.51% <0.00%> (-53.00%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/nn/resolver.py 90.00% <0.00%> (-6.67%) ⬇️
torch_geometric/io/tu.py 93.90% <0.00%> (-2.44%) ⬇️
torch_geometric/nn/models/mlp.py 98.52% <0.00%> (-1.48%) ⬇️
torch_geometric/transforms/gdc.py 78.17% <0.00%> (-1.02%) ⬇️
torch_geometric/data/dataset.py 96.80% <0.00%> (-0.80%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d76627...93fe714. Read the comment docs.

@rusty1s rusty1s merged commit f909d24 into master Jun 22, 2022
@rusty1s rusty1s deleted the han_conv_nan branch June 22, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HANConv with empty tensor input may cause NaN value
1 participant