Skip to content

Add more support for functional groups #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

mrbean-bremen
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2023

Codecov Report

Merging #37 (c81dd46) into main (f1e722e) will increase coverage by 0.34%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   87.63%   87.97%   +0.34%     
==========================================
  Files          14       14              
  Lines        1480     1489       +9     
==========================================
+ Hits         1297     1310      +13     
+ Misses        183      179       -4     
Files Changed Coverage Δ
dicom_validator/spec_reader/condition.py 94.84% <ø> (ø)
dicom_validator/spec_reader/condition_parser.py 98.88% <100.00%> (+0.02%) ⬆️
dicom_validator/spec_reader/part3_reader.py 96.17% <100.00%> (-0.04%) ⬇️
dicom_validator/validator/iod_validator.py 93.03% <100.00%> (+1.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

- add checks for macros that are not allowed in shared
  or per-frame functional groups
- add check that macros are not present in both shared
  and per-frame functional groups
- closes pydicom#27
@mrbean-bremen mrbean-bremen merged commit 5a49607 into pydicom:main Aug 13, 2023
@mrbean-bremen mrbean-bremen deleted the multi-frame-cond branch April 5, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with (5200,9229) Shared Functional Groups Sequence for X-ray 3d craniofacial image in 0.3.5
2 participants