Fix handling of missing values #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mrbean-bremen
commented
Jul 22, 2023
mrbean-bremen
commented
- if the values for a condition needing a value cannot be parsed, the condition is now ignored
- fixes Condition parsing issue on 0.3.4 #20
- add handling of a few more simple conditions
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 87.94% 87.83% -0.12%
==========================================
Files 14 14
Lines 1369 1381 +12
==========================================
+ Hits 1204 1213 +9
- Misses 165 168 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- if the values for a condition needing a value cannot be parsed, the condition is now ignored - fixes pydicom#20 - add handling of a few more simple conditions
mrbean-bremen
force-pushed
the
missing-values
branch
from
6ce341a to
9e9207f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.