Allow other VR Types for Date Jitter #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Adjusted ctbrain1.dcm file to contain non-DA/DT date field, added test method.
When implementing unit test for jittering on values lists, identified a bug which prevented private fields from being jittered. Modified jitter_timestamp to simply return the new value of the field and use replace_field() to actually perform the dicom update.
Fixing formatting for PR.
Correcting formatting for PR.
|
Thank you @wetzelj ! Let's merge and get this release underway. Sorry for the git-fu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues: #175, #180, #181
Pull requests #180 and #181 were originally based on master before #178 had been merged into master. This pull request merges the latest changes in master with the changes necessary for #175, #180, #181.
The changes that had previously been implemented for #178 were revised with the implementation of changes for #175.
This pull request will supersede #180 and #181. Both of the prior PRs can simply be closed.
Checklist
Open questions
Questions that require more discussion or to be addressed in future development: