fixing issue #153 that fields are not properly indexed #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this leads to an error in replacement of nested fields and top level fields having mixed up references. We fixed this by iterating through the dataset as is, instead of using iterall. Signed-off-by: vsoch <[email protected]>
…tain filters (#156) * Change to return results from detect when recipe does not contain filters Co-authored-by: Wetzel <[email protected]> Co-authored-by: Mike Ciancibello <[email protected]>
wetzelj
approved these changes
Oct 2, 2020
|
Thanks @wetzelj ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this leads to an error in replacement of nested fields and top level fields having mixed up references. We fixed this by iterating through the dataset as is, instead of using iterall.
Signed-off-by: vsoch [email protected]
Description
Related issues: #153
Please include a summary of the change(s) and if relevant, any related issues above.
Checklist
Open questions
Questions that require more discussion or to be addressed in future development: