Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Zarr region="auto" tests to a class #9990

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

dcherian
Copy link
Contributor

Simply reorganizes the existing region="auto" tests in to a class. I'm finding this useful for downstream icechunk development.

@dcherian dcherian requested a review from jhamman January 27, 2025 17:51
dcherian added a commit to earth-mover/icechunk that referenced this pull request Jan 27, 2025
@dcherian dcherian changed the title Migrate region tests to Zarr test class Migrate Zarr region="auto" tests to a class Jan 27, 2025
@requires_zarr
@requires_dask
@pytest.mark.usefixtures("default_zarr_format")
def test_zarr_region_chunk_partial_offset(tmp_path):
Copy link
Contributor Author

@dcherian dcherian Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just indented in and replaced to_zarr with self.save

@dcherian dcherian added the plan to merge Final call for comments label Jan 27, 2025
@dcherian dcherian merged commit 5fdceff into pydata:main Jan 29, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant