Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time_unit argument to CFTimeIndex.to_datetimeindex #9965

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add time_unit argument to CFTimeIndex.to_datetimeindex #9965

wants to merge 7 commits into from

Conversation

spencerkclark
Copy link
Member

Per #9618 (comment), this PR adds a time_unit keyword argument to CFTimeIndex.to_datetimeindex. The default is None, which currently means the dates will be converted to nanosecond-resolution np.datetime64 values, but a FutureWarning is raised indicating that this will eventually be switched to return microsecond-precision np.datetime64 values.

cc: @dcherian @kmuehlbauer

  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@spencerkclark spencerkclark force-pushed the to_datetimeindex-update branch 4 times, most recently from 1732fa7 to aad1c76 Compare January 20, 2025 19:05
@spencerkclark spencerkclark force-pushed the to_datetimeindex-update branch from f421467 to 6e49c2a Compare January 20, 2025 19:17
kmuehlbauer
kmuehlbauer approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking care of the CFTimeIndex changes. It looks really complete 🚀. Just some more minor typing which could be added.

xarray/tests/test_cftime_offsets.py Outdated Show resolved Hide resolved
xarray/tests/test_cftimeindex.py Outdated Show resolved Hide resolved
xarray/tests/test_groupby.py Outdated Show resolved Hide resolved
xarray/tests/test_missing.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmuehlbauer kmuehlbauer kmuehlbauer approved these changes

Assignees
No one assigned
Labels
topic-cftime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencerkclark @kmuehlbauer