Avoid unsafe casts from float to unsigned int #9964
Conversation
QuLogic
force-pushed
the
float-uint-casts
branch
from
6b366de to
fefab07
Compare
| if xp == np: | ||
| # numpy currently doesn't have a view: | ||
| return data.view(*args, **kwargs) | ||
| return xp.view(data, *args, **kwargs) |
There was a problem hiding this comment.
Which package supports this? I can't find xp.view in the standard https://data-apis.org/array-api/draft/API_specification/index.html
There was a problem hiding this comment.
Oh, I didn't realize this was implementing a standard when @kmuehlbauer brought it up in #9815. As in #9815, it works for NumPy and Dask. I don't know about any other packages other than tests don't seem to fail about it specifically.
There was a problem hiding this comment.
I didn't check this fully, but to be honest, I also tried it the same way locally.
@Illviljan can you suggest a way forward here, so that it is usable for numpy and dask?
There was a problem hiding this comment.
I can also try view and fall back to astype(copy=False) if that's more portable. And also not expose view so publicly if desired.
Note that this adds
.viewtoduck_array_ops; I'm not certain if this is new user API or not.This works across all non-x86_64 architectures in Fedora. I did not test RISC-V, as that is not a primary architecture, but it is likely the same issue and maybe @U2FsdGVkX1 can give it a try.
whats-new.rstapi.rst