Coordinate -> IndexVariable and other deprecations #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed the ``Coordinate`` class from xarray's low level API to ``IndexVariable``. - Deprecated supplying ``coords`` as a dictionary to the ``DataArray`` constructor without also supplying an explicit ``dims`` argument. The old behavior encouraged relying on the iteration order of dictionaries, which is a bad practice (GH727). - Removed a number of methods deprecated since v0.7.0 or earlier: ``load_data``, ``vars``, ``drop_vars``, ``dump``, ``dumps`` and the ``variables`` keyword argument alias to ``Dataset``.
Member
|
Maybe we should also rename |
Member
Author
Good catch, I meant to include this. |
Member
Author
|
@benbovy any preference on whether I should submit this before or after your PR? |
Member
|
@shoyer feel free to merge this when you want. I can rebase my branch and resolve conflicts if needed. |
Member
Author
|
OK, in it goes! |
mzuehlke
added a commit
to CCI-Tools/xarray
that referenced
this pull request
Jul 12, 2017
shoyer
pushed a commit
that referenced
this pull request
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coordinateclass from xarray's low level API toIndexVariable. xref Multi-index levels as coordinates #947 (comment)coordsas a dictionary to theDataArrayconstructor without also supplying an explicit
dimsargument. The oldbehavior encouraged relying on the iteration order of dictionaries, which is
a bad practice (fixes DataArray creation prone to errors when data shares dimension shapes #727).
load_data,vars,drop_vars,dump,dumpsand thevariableskeyword argument alias toDataset.