-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate formatting_html.py into xarray core #8930
Merged
TomNicholas
merged 14 commits into
pydata:main
from
flamingbear:DAS-2066-migrate-formatting-html
Apr 18, 2024
Merged
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e7a5f4a
DAS-2066: formatting_html.py merge
eni-awowale 1af00bc
Revert "DAS-2066: formatting_html.py merge"
eni-awowale 015e43f
Adding datatree functions to core
eni-awowale 3034b35
Deleted formatting_html.py and test_formatting_html.py in datatree_
eni-awowale e16a01c
renamed all of the relevant functions so they represent datatree
eni-awowale a5e143a
added comment for mypy
eni-awowale 4313d15
added dict[any, any] as type hint for children
eni-awowale 6ce9211
added dict[Any, Any] as type hint for children
eni-awowale 2d8f104
updated typhint to dict[str, DataTree] and increased pixel min width …
eni-awowale 4e1def6
replaced Any with DataTree
eni-awowale 33fb7de
added type checking
eni-awowale bf18075
DAS-2066 - Incorporate CSS changes for DataTree display.
owenlittlejohns fdf53f5
DAS-2066 - Fix tests.
owenlittlejohns ed83ad2
Merge remote-tracking branch 'pydata/main' into DAS-2066-migrate-form…
flamingbear File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this
Any
really aDataTree
? (Not 100% sure, but it seems like a good guess)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing up the type hints!