Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use opt_einsum by default if installed. #8373

Merged
merged 12 commits into from
Oct 28, 2023
Merged

Use opt_einsum by default if installed. #8373

merged 12 commits into from
Oct 28, 2023

Conversation

dcherian
Copy link
Contributor

@github-actions github-actions bot added topic-arrays related to flexible array support CI Continuous Integration tools dependencies Pull requests that update a dependency file labels Oct 25, 2023
max-sixty
max-sixty reviewed Oct 25, 2023
View reviewed changes
@dcherian @max-sixty
_
8b7d80f 
Co-authored-by: Maximilian Roos <[email protected]>
@dcherian @max-sixty
Update xarray/core/computation.py
de1bead 
Co-authored-by: Maximilian Roos <[email protected]>
@dcherian
Copy link
Contributor Author

dcherian commented Oct 25, 2023 •
edited
Loading

I added a global option since this path is used for .weighted.sum and for the @ binary operator

@dcherian dcherian requested review from keewis and max-sixty October 25, 2023 21:10
max-sixty
max-sixty approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

keewis
keewis approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, and I'm fine with skipping tests with pint for now.

Do you know what would be needed to change that, though? If so, I'd be willing to make that change for pint.

doc/conf.py
@@ -326,6 +327,7 @@
"sparse": ("https://sparse.pydata.org/en/latest/", None),
"cubed": ("https://tom-e-white.com/cubed/", None),
"datatree": ("https://xarray-datatree.readthedocs.io/en/latest/", None),
# "opt_einsum": ("https://dgasmith.github.io/opt_einsum/", None),
Copy link
Collaborator

@keewis keewis Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the opt_einsum project is using mkautodoc, which doesn't seem to generate a intersphinx inventory (mkdocstrings would be able to). So I guess this would need interaction with that project.

@dcherian
Copy link
Contributor Author

Do you know what would be needed to change that, though?

Add np.tensordot support.

@dcherian dcherian added the plan to merge Final call for comments label Oct 25, 2023
@dcherian dcherian merged commit d40609a into pydata:main Oct 28, 2023
@dcherian dcherian deleted the opt-einsum branch October 28, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

@keewis keewis keewis approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration tools dependencies Pull requests that update a dependency file plan to merge Final call for comments topic-arrays related to flexible array support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recommend optimize=True in xr.dot docstring Support opt_einsum in xr.dot
3 participants
@dcherian @max-sixty @keewis