New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing issues in tests #8312

Merged

Illviljan merged 2 commits into pydata:main from Illviljan:mypy_tests

Oct 16, 2023

Contributor

Illviljan commented Oct 15, 2023 •

edited

Loading

Seen in #8294.

These tests implicitly made sure the type was correct in a way that type checkers wont understand. Make it explicit instead.


          Fix typing issues in tests

e838ca8

Contributor Author

Illviljan commented Oct 15, 2023

xarray/tests/test_variable.py:620: error: Unused "type: ignore" comment  [unused-ignore]

Not relevant yet I suppose.


          Update test_variable.py

376c13d

Illviljan added the plan to merge label

Illviljan merged commit 014ab81 into pydata:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels