-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite typed_ops #8204
Rewrite typed_ops #8204
Conversation
(Looks great so far!) |
Basically all type: ignores in the new tests are currently broken. Why some of the python type ops are failing I have to investigate. |
Wow, this turns out to be more tricky than I thought. I really need a way to specify that we support ArrayLike but not DataArrays..... |
Now this PR brings the static typing of the ops methods to the best we can currently achieve.
The added "unit" tests (basically only checks for mypy) have type ignores for these cases, so we will realize when something upstream has changed. |
"invoking the `to_array()` method." | ||
) | ||
if TYPE_CHECKING: | ||
# needed because __getattr__ is returning Any and otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the issue that is also causing this problem here: #4601
Awesome job @headtr1ck ! Very impressive, thank you. |
whats-new.rst