Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to sort hashable, map to string #8172

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Don't try to sort hashable, map to string #8172

merged 6 commits into from
Sep 11, 2023

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Sep 11, 2023 •
edited
Loading

Fixes the mypy error we're seeing in the CI at the moment:

xarray/core/dataset.py:5286: error: Value of type variable "SupportsRichComparisonT" of "sorted" cannot be "Hashable"  [type-var]

Can't sort Hashables apparently.

@Illviljan Illviljan marked this pull request as draft September 11, 2023 17:10
@Illviljan Illviljan changed the title Update dataset.py Don't try to sort hashable Sep 11, 2023
@Illviljan Illviljan marked this pull request as ready for review September 11, 2023 17:37
@Illviljan Illviljan changed the title Don't try to sort hashable Don't try to sort hashable, map to string Sep 11, 2023
@Illviljan Illviljan merged commit 3edd997 into pydata:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Illviljan