Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut middle version from CI #8156

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Cut middle version from CI #8156

merged 1 commit into from
Sep 7, 2023

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Sep 7, 2023

Testing for 3.10 seems fairly low value — is there a realistic case where 3.10 would fail but 3.9 & 3.11 would pass?

Merging this would cut the CI queue...

This seems fairly low value -- is there a case where 3.10 would fail but 3.9 & 3.11 would pass?

It'll cut the CI queue
@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Sep 7, 2023
@max-sixty max-sixty merged commit c9946ec into pydata:main Sep 7, 2023
@kmuehlbauer
Copy link
Contributor

Might only help if different versions of dependencies are pulled in. But that might be such a rare case the user issues should be enough to handle.

We would need to remove the status checks from the required tests in the repo Settings-Branches.

@kmuehlbauer
Copy link
Contributor

I've removed those builds from required tests in the repo Settings-Branches.

@max-sixty
Copy link
Collaborator Author

FYI one thing we do in PRQL is have a limited set of tests on PRs which cover 98% of cases with about 30% of the runtime — and then the full set of tests after merge. (And an even fuller set every night)

So we could do that sort of thing here if we wanted to ensure we see very rare issues before a user does without slowing down PRs.

(Not sure whether CI queues are a problem though, not worth spending time on it they're not)

@max-sixty max-sixty deleted the ci branch September 7, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Github bots, testing workflows, release automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants