-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow apply_ufunc
to ignore missing core dims
#8138
Conversation
Any thoughts on this, team? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may have to think about how we handle multiple input_vars and what happens if multiple ds
are passed (e.g apply_ufunc(func, ds1, ds2)
). But that are probably rather edge-cases.
What's the best name for this arg?
|
2bc743f
to
b31b170
Compare
b31b170
to
ebe707b
Compare
OK, I'm reasonably happy with this now — it's ready to go, pending docs & changelog. Any thoughts prior? |
Sorry, just saw this. Yes, I actually had a TODO prior re adding tests for this, which I just added. In the case of |
Co-authored-by: Deepak Cherian <[email protected]>
Co-authored-by: Deepak Cherian <[email protected]>
* Allow `apply_ufunc` to ignore missing core dims * Display data returned in ufunc error message This makes debugging much easier! * Add tests for multiple var dataset * Update xarray/core/computation.py Co-authored-by: Deepak Cherian <[email protected]> * Update xarray/core/computation.py Co-authored-by: Deepak Cherian <[email protected]> * more error message changes --------- Co-authored-by: Deepak Cherian <[email protected]>
whats-new.rst
api.rst
This probably needs a review and another turn, maybe some more tests on multiple objects etc. There are a couple of questions inline.