Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tokenize with empty attrs #8101

Merged
merged 5 commits into from
Sep 9, 2023
Merged

Fix tokenize with empty attrs #8101

merged 5 commits into from
Sep 9, 2023

Conversation

malmans2
Copy link
Contributor

@malmans2 malmans2 commented Aug 23, 2023 •
edited
Loading

@malmans2 malmans2 marked this pull request as ready for review August 23, 2023 06:29
@malmans2 @Illviljan
typing
693e52c 
Co-authored-by: Illviljan <[email protected]>
@dcherian dcherian enabled auto-merge (squash) August 31, 2023 02:05
@dcherian
Copy link
Contributor

Thanks @malmans2

@andersy005 this will introduce a minor conflict.

@dcherian dcherian mentioned this pull request Aug 31, 2023
Closed
@kmuehlbauer kmuehlbauer mentioned this pull request Sep 1, 2023
Closed
3 tasks
@dcherian dcherian added the plan to merge Final call for comments label Sep 8, 2023
@dcherian dcherian disabled auto-merge September 9, 2023 04:53
@dcherian dcherian merged commit aea9af0 into pydata:main Sep 9, 2023
@malmans2 malmans2 deleted the tokenize-variable branch January 27, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Illviljan Illviljan Illviljan approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

empty attributes silently change
3 participants
@malmans2 @dcherian @Illviljan