Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document drop_variables in open_mfdataset #8083

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

jerabaul29
Copy link
Contributor

Document drop_variables in open_mfdataset. Makes it even clearer that for more information about possible additional options to open_mfdataset, one can consult open_dataset. Solves the comment at #8074 (comment) .

@welcome
Copy link

welcome bot commented Aug 18, 2023

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

@jerabaul29
Copy link
Contributor Author

(I do not really understand while these tests fail, but I suppose this is not related to the minor documentation update I just pushed?)

Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR @jerabaul29!

So what I was suggesting was actually to add a new example to the examples section of the open_mfdataset docstring, the section that starts with

Examples
--------

i.e. add a small code snippet demonstrating passing on the of the open_dataset arguments down through open_mfdataset.

@jerabaul29
Copy link
Contributor Author

Thanks for your patience and kind explanation, sorry for misunderstanding at first. Does this look better? :)

Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @jerabaul29!

@dcherian dcherian merged commit 1043a9e into pydata:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants