-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document drop_variables in open_mfdataset #8083
Document drop_variables in open_mfdataset #8083
Conversation
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
(I do not really understand while these tests fail, but I suppose this is not related to the minor documentation update I just pushed?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening a PR @jerabaul29!
So what I was suggesting was actually to add a new example to the examples section of the open_mfdataset
docstring, the section that starts with
Examples
--------
i.e. add a small code snippet demonstrating passing on the of the open_dataset
arguments down through open_mfdataset
.
Thanks for your patience and kind explanation, sorry for misunderstanding at first. Does this look better? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @jerabaul29!
Document
drop_variables
inopen_mfdataset
. Makes it even clearer that for more information about possible additional options toopen_mfdataset
, one can consultopen_dataset
. Solves the comment at #8074 (comment) .