-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Count documentation #8057
Count documentation #8057
Conversation
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
Looks like you did really well. Thanks!
Are you interested in adding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
You can add an entry in whats-new:)
I guess long term we should clean up the generation script a bit and remove all the special casings with dicts (or default dicts). But that's another PR.
for more information, see https://pre-commit.ci
I would be glad to do so if I find the time in the next few days! Should such a field be used only for |
#7378 suggests that most, if not all, methods would benefit from an extra line or two. I'll merge this one since it's a pretty good upgrade already. Thanks! |
Dataset.count()
is ambiguous #8055whats-new.rst
I've changed the example to include a 0 value which clearly shows that only NA values are ignored in the count. I've only modified the "see also" section for
count
since as mentioned in #8055 it is a bit of an outlier among the aggregation methods. I believe that this is not a long term fix since the single line summary of the method is of little use, but at least with this no one will have to take a look at the source code to quickly get whatcount
does.Feel free to correct any problems or suggest any changes, as I am quite new to contributing to projects like this and have little idea of what I'm doing 😅