Fix check for chunk_store in zarr backend #7923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
github-actions
bot
added
io
topic-backends
topic-zarr
|
Thanks! Can you add a test please? |
juntyr
force-pushed
the
zarr-chunk-store-fix
branch
from
20e13e8 to
9687112
Compare
|
Thanks @juntyr This is a great first contribution. Welcome to Xarray! |
jhamman
approved these changes
Jun 23, 2023
Illviljan
reviewed
Jun 23, 2023
|
@TomNicholas do you want to merge this before or after tagging the release? |
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
dstansby
pushed a commit
to dstansby/xarray
that referenced
this pull request
Jun 28, 2023
* Fix check for chunk_store in zarr backend * Add test and update whats-new * Update the whats-new message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zarr stores implement the
__len__method and thus checking if a store is truthy returns if the store is non-empty, not if thechunk_storevariable is stillNone. With this fix, empty stores can be passed aschunk_storeto theto_zarr(...)method and will actually be used.whats-new.rstapi.rst