use trusted publishers instead of a API token #7899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Automation
|
Just did it. |
|
great, thanks. Not sure how to verify this is working when we're not actually releasing, but I can push a tag to publish a rc/alpha version to TestPyPI. Edit: once we verified it works I will delete the API tokens from the secrets. |
|
Shall we merge? |
andersy005
approved these changes
Jun 14, 2023
|
after relaxing the environment rules (not sure how we can restrict publishing to just |
dstansby
pushed a commit
to dstansby/xarray
that referenced
this pull request
Jun 28, 2023
* use trusted publishers instead of a API token * same for TestPyPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyPI introduced the concept of "trusted publishers" a few months ago, which allows requesting short-lived API tokens for trusted publishing services (such as GHA, in our case).
Someone with the appropriate rights will have to enable this on PyPI, and I will do the same for TestPyPI.