Changed duck typing exception to: (ImportError, AttributeError) #7874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow checking for missing attributes in imported packages
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
keewis
approved these changes
May 25, 2023
TomNicholas
reviewed
May 26, 2023
TomNicholas
reviewed
May 26, 2023
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
dstansby
pushed a commit
to dstansby/xarray
that referenced
this pull request
Jun 28, 2023
…ta#7874) * Changed duck typing exception to (ImportError, AttributeError) to allow checking for missing attributes in imported packages * Updated whats-new.rst with the duck typing exception catch update of PR 7874. * Remove accidental url in whats-new * Issue number in whats-new.rst --------- Co-authored-by: Tom Nicholas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #7870, there is a name-collision with the astrophysics package
pint-pulsar, which is used to do high-precision pulsar timing. That other package would get imported aspint, and anAttributeErroris thrown because that imported package is not the expected package.By generalizing the duck typing exception to catch an
ImportErrorand anAttributeError, we catch such name-collisions. It fits the idea and goal of duck typing.This PR is a single-line change