Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .groupby(multi index level) #7830

Merged
merged 5 commits into from
Jun 6, 2023

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented May 8, 2023

@dcherian dcherian requested a review from benbovy May 8, 2023 23:16
Copy link
Contributor

@Illviljan Illviljan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have to add a dummy .to_index to _DummyGroup as well.

xarray/tests/test_groupby.py Outdated Show resolved Hide resolved
@dcherian dcherian added the plan to merge Final call for comments label Jun 2, 2023
@dcherian dcherian merged commit c668582 into pydata:main Jun 6, 2023
@dcherian dcherian deleted the fix-groupby-midx-level branch June 6, 2023 00:21
dstansby pushed a commit to dstansby/xarray that referenced this pull request Jun 28, 2023
* Fix .groupby(multi index level)

Closes pydata#6836

* Update xarray/tests/test_groupby.py

* mypy: Add _DummyGroup.to_index

---------

Co-authored-by: Illviljan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments topic-groupby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

groupby(multi-index level) not working correctly on a multi-indexed DataArray or DataSet
2 participants