Skip to content

[skip-ci] Fix groupby binary ops benchmarks #7603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcherian merged 5 commits into from
Mar 16, 2023
Merged

[skip-ci] Fix groupby binary ops benchmarks #7603

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b0d600
[skip-ci] Fix groupby binary ops benchmarks
dcherian Mar 10, 2023
c90a80a
[skip-ci] fix
dcherian Mar 10, 2023
495dcf7
[skip-ci] xfail resample binary ops
dcherian Mar 14, 2023
65a01ee
[skip-ci] add skipping message
dcherian Mar 14, 2023
3452193
[skip-ci] remove resample binary ops
dcherian Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 12 additions & 24 deletions asv_bench/benchmarks/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,17 @@ def time_agg_large_num_groups(self, method, ndim):
ds = getattr(self, f"ds{ndim}d")
getattr(ds.groupby("b"), method)()

def time_groupby_binary_op_1d(self):
self.ds1d - self.ds1d_mean
def time_binary_op_1d(self):
self.ds1d.groupby("b") - self.ds1d_mean

def time_groupby_binary_op_2d(self):
self.ds2d - self.ds2d_mean
def time_binary_op_2d(self):
self.ds2d.groupby("b") - self.ds2d_mean

def peakmem_groupby_binary_op_1d(self):
self.ds1d - self.ds1d_mean
def peakmem_binary_op_1d(self):
self.ds1d.groupby("b") - self.ds1d_mean

def peakmem_groupby_binary_op_2d(self):
self.ds2d - self.ds2d_mean
def peakmem_binary_op_2d(self):
self.ds2d.groupby("b") - self.ds2d_mean


class GroupByDask(GroupBy):
Expand All @@ -71,10 +71,10 @@ def setup(self, *args, **kwargs):
self.ds1d = self.ds1d.to_dataframe()
self.ds1d_mean = self.ds1d.groupby("b").mean()

def time_groupby_binary_op_2d(self):
def time_binary_op_2d(self):
raise NotImplementedError

def peakmem_groupby_binary_op_2d(self):
def peakmem_binary_op_2d(self):
raise NotImplementedError


Expand All @@ -90,10 +90,10 @@ def setup(self, *args, **kwargs):
self.ds1d = self.ds1d.chunk({"dim_0": 50}).to_dataframe()
self.ds1d_mean = self.ds1d.groupby("b").mean()

def time_groupby_binary_op_2d(self):
def time_binary_op_2d(self):
raise NotImplementedError

def peakmem_groupby_binary_op_2d(self):
def peakmem_binary_op_2d(self):
raise NotImplementedError


Expand Down Expand Up @@ -123,18 +123,6 @@ def time_agg_large_num_groups(self, method, ndim):
ds = getattr(self, f"ds{ndim}d")
getattr(ds.resample(time="48H"), method)()

def time_groupby_binary_op_1d(self):
self.ds1d - self.ds1d_mean

def time_groupby_binary_op_2d(self):
self.ds2d - self.ds2d_mean

def peakmem_groupby_binary_op_1d(self):
self.ds1d - self.ds1d_mean

def peakmem_groupby_binary_op_2d(self):
self.ds2d - self.ds2d_mean


class ResampleDask(Resample):
def setup(self, *args, **kwargs):
Expand Down