-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Codecov #7142
Fix Codecov #7142
Conversation
headtr1ck
commented
Oct 7, 2022
- Closes Coverage shows reduced value since mypy flag was added #7141
@shoyer @max-sixty do you know who has rights to change the default branch to main on codecov.io? |
See also issue on codecov: |
I just did this (and ofc happy to give you permission if it's helpful) Though I still see the issue on |
I just noticed our very low coverage rating and found this PR. Did this PR work? Should we update it and merge? It would be great to have our coverage back in the 90s rather than the 50s 😝 . |
Unfortunately it does not work :/ Feel free to push the issue :) |
I'm currently on holidays and mobile only. @andersy005 thanks for looking into this, did your changes fix things? You can also talk to Tom over at https://community.codecov.com/t/wrong-coverage-number-in-badge-with-flags |