Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set keep_attrs for flox #6667

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Set keep_attrs for flox #6667

merged 1 commit into from
Jun 6, 2022

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Jun 6, 2022

Closes #6666

False by default following Dataset.reduce

Closes pydata#6666

False by default following Dataset.reduce
@dcherian dcherian mentioned this pull request Jun 6, 2022
1 task
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dcherian!

@andersy005 andersy005 changed the title [test-upstream] Set keep_attrs for flox Set keep_attrs for flox Jun 6, 2022
@andersy005 andersy005 merged commit 6ef7425 into pydata:main Jun 6, 2022
dcherian added a commit to dcherian/xarray that referenced this pull request Jun 12, 2022
* main:
  pass kwargs through from save_mfdataset to to_netcdf (pydata#6686)
  Docs: indexing.rst finetuning (pydata#6685)
  use micromamba instead of mamba (pydata#6674)
  install the development version of `matplotlib` into the upstream-dev CI (pydata#6675)
  Add whatsnew section for v2022.06.0
  release notes for 2022.06.0rc0
  release notes for the pre-release (pydata#6676)
  more testpypi workflow fixes (pydata#6673)
  thin: add examples (pydata#6663)
  Update multidimensional-coords.ipynb (pydata#6672)
  try to finally fix the TestPyPI workflow (pydata#6671)
  pin setuptools in the modify script (pydata#6669)
  fix the python version for the TestPyPI workflow (pydata#6668)
  upload wheels from `main` to TestPyPI (pydata#6660)
  Set keep_attrs for flox (pydata#6667)
@dcherian dcherian deleted the flox-keep-attrs branch September 12, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Nightly upstream-dev CI failed ⚠️
2 participants